Hello There, Guest! Register


Minor CSS bug fix
vtk Offline
Member
Registered

Posts: 65
Threads: 7
Joined: Feb 2018
1 Attached Account
#1
 
Minor CSS bug fix

I have noticed in new posts since the forum upgrade, quotes in replies sometimes have messed-up date displays. Like, where it's supposed to say something like "(8 hours ago)" it actually comes out looking like "()8 hours ago". See attachment. (Edit: this apparently affects the Dark and Light themes.)

On investigating, I found this is because, while the <SPAN> element containing the whole date gets (and is supposed to get) the style "float: right", it also contains an inner <SPAN> element around the "8 hours ago" text so that it can have hover-text, and that inner <SPAN> element also gets the style "float: right" which is what makes it get a weird layout on the screen.

I found the following in the CSS for the site:
Code:
blockquote cite span {
    float: right;
    font-weight: normal;
}

These two rules are applied to any <SPAN> inside any <CITE> inside any <BLOCKQUOTE>, including a <SPAN> in a <SPAN> in a <CITE> in a <BLOCKQUOTE>, which is not what we want here. What we want is to only apply these rules to a <SPAN> which is a direct subelement of a <CITE> in a <BLOCKQUOTE>, so it won't also apply to a <SPAN> within a <SPAN> in a <CITE> in a <BLOCKQUOTE>. To do this, we need only make a slight change to the selector in the CSS:
Code:
blockquote cite > span {
    float: right;
    font-weight: normal;
}

This probably won't break anything, unless there is somewhere an instance of a <SPAN> that should get the "float: right" style and is a subelement of some element other than <CITE> which is in a <CITE> in a <BLOCKQUOTE>.


Attached Files Thumbnail(s)
   

Maggie David (she or they, birthday June 4)
(This post was last modified: 03-15-2018, 06:19 AM by vtk.)
03-15-2018, 06:12 AM
Find Reply

Sponsors:
Lolflash - click it, you know you want to

Luminesce Offline
loves the moon
Registered

Posts: 1,499
Threads: 12
Joined: Apr 2014
4 Attached Accounts
#2
 
RE: Minor CSS bug fix

Yeah, I immediately noticed this too and brought it up, but I sure didn't know why it happened or how to fix it.

Hi! I'm Lumi, host of Reisen, Tewi, Flandre and Lucilyn.
Everyone deserves to love and be loved. It's human nature.
My tulpas and I have a Q&A thread, which was the first (and largest) of its kind. Feel free to ask us stuff.
03-15-2018, 02:00 PM
Find Reply
Pleeb Offline
Owner
Forum Administrators

Posts: 850
Threads: 71
Joined: May 2012
2 Attached Accounts
#3
 
RE: Minor CSS bug fix

(03-15-2018, 02:00 PM)Luminesce Wrote: Yeah, I immediately noticed this too and brought it up, but I sure didn't know why it happened or how to fix it.

Test

EDIT: Thanks for finding that bug.... Fixed!
(This post was last modified: 03-15-2018, 11:32 PM by Pleeb.)
03-15-2018, 11:32 PM
Website Find Reply
vtk Offline
Member
Registered

Posts: 65
Threads: 7
Joined: Feb 2018
1 Attached Account
#4
 
RE: Minor CSS bug fix

Now that I'm looking at this on my phone again, I'm reminded that the mobile theme also appears to be affected

Maggie David (she or they, birthday June 4)
03-16-2018, 10:34 AM
Find Reply
Pleeb Offline
Owner
Forum Administrators

Posts: 850
Threads: 71
Joined: May 2012
2 Attached Accounts
#5
 
RE: Minor CSS bug fix

Whoops I'll fix that too later today- I just noticed on my phone as well
03-16-2018, 10:41 AM
Website Find Reply
jean-luc Offline
capt@in.jean-luc.org
Patron

Posts: 697
Threads: 53
Joined: Nov 2012
2 Attached Accounts
#6
 
RE: Minor CSS bug fix

Now I see it as

(, 07:00 AM)Yesterday

(on mobile theme)

Host: Jean-luc (plain-colored text)
Tulpas: Snow & Henry
Choose your tulpas' colors here!
Click here if you'd like a changing avatar like mine!
Ain't that just fantitiliantastic!
I host a podcast called Tulpaudcast.
and ramble crazily about everything while walking on Jean-luc walking.
03-16-2018, 07:25 PM
Find Reply
Pleeb Offline
Owner
Forum Administrators

Posts: 850
Threads: 71
Joined: May 2012
2 Attached Accounts
#7
 
RE: Minor CSS bug fix

Should be fixed now.
03-18-2018, 01:20 AM
Website Find Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)

Sponsors:
Lolflash - click it, you know you want to


Contact Us | Tulpa.Info | Return to Top | Return to Content | Mobile Version | RSS Syndication